Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/694#discussion_r38002218
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
    @@ -18,23 +18,23 @@
       (:import [backtype.storm.generated Grouping]
                [java.io Serializable])
       (:use [backtype.storm util config log timer stats])
    -  (:import [java.util List Random HashMap ArrayList LinkedList Map])
    +  (:import [java.util List Random HashMap ArrayList Map])
       (:import [backtype.storm ICredentialsListener])
    -  (:import [backtype.storm.hooks ITaskHook])
    -  (:import [backtype.storm.tuple Tuple Fields TupleImpl MessageId])
    +  (:import [backtype.storm.tuple Tuple Fields TupleImpl MessageId Batch])
       (:import [backtype.storm.spout ISpoutWaitStrategy ISpout 
SpoutOutputCollector ISpoutOutputCollector])
       (:import [backtype.storm.hooks.info SpoutAckInfo SpoutFailInfo
                 EmitInfo BoltFailInfo BoltAckInfo BoltExecuteInfo])
       (:import [backtype.storm.grouping CustomStreamGrouping])
       (:import [backtype.storm.task WorkerTopologyContext IBolt 
OutputCollector IOutputCollector])
       (:import [backtype.storm.generated GlobalStreamId])
    -  (:import [backtype.storm.utils Utils MutableObject RotatingMap 
RotatingMap$ExpiredCallback MutableLong Time])
    +  (:import [backtype.storm.utils Utils MutableObject RotatingMap 
RotatingMap$ExpiredCallback MutableLong Time DisruptorQueue])
       (:import [com.lmax.disruptor InsufficientCapacityException])
    -  (:import [backtype.storm.serialization KryoTupleSerializer 
KryoTupleDeserializer])
    +  (:import [backtype.storm.serialization KryoTupleSerializer 
KryoBatchSerializer KryoTupleBatchSerializer KryoTupleBatchDeserializer])
       (:import [backtype.storm.daemon Shutdownable])
    -  (:import [backtype.storm.metric.api IMetric IMetricsConsumer$TaskInfo 
IMetricsConsumer$DataPoint StateMetric])
    +  (:import [backtype.storm.metric.api IMetric IMetricsConsumer$TaskInfo 
IMetricsConsumer$DataPoint])
       (:import [backtype.storm Config Constants])
    -  (:import [java.util.concurrent ConcurrentLinkedQueue])
    +  (:import [java.util.concurrent ConcurrentLinkedQueue]
    +           (backtype.storm.messaging TaskMessage))
    --- End diff --
    
    It would be nice to make this a vector, for consistency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to