Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135152145
The changes look fine to me. +1
@harshach we did a similar thing for the HDFS Bolt.
https://github.com/apache/storm/blob/ffb1562cb0eb3fbd916423136fcd3c181fbf6212/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java#L53-L56
Each bolt needs to be able to be configured independently of all other
bolts. Putting it in the conf is a is one way to do it, but I have seen a lot
of bolts do it through a setter too. I personally would prefer to support both
through a config and through an API. The only trick is with consistency and
ordering in the case of conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
