Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/707#issuecomment-135885006
@alexpanov
Nice work. I have some comments for this PR,
1.
I found you're refactoring whole codes which I think is better to file
several new issues to JIRA respectively.
Please keep diffs simple and small enough, and try to avoid introducing
unrelated diffs.
2.
Seems like you need to update your working directory before starting.
I merged #679 into master after merging #693, which was conflicted.
3. storm-core relocates guava's package for avoiding conflicts.
I'm not 100% sure, but I think it means that if we need to use guava from
outer of storm-core, guava should be added as dependency explicitly.
Any other external modules already did it, though I think it would be
better to relocate guava again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
