[ 
https://issues.apache.org/jira/browse/STORM-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720590#comment-14720590
 ] 

ASF GitHub Bot commented on STORM-1008:
---------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/698#issuecomment-135889977
  
    Great. +1.


> Isolate the code for metric collection and retrieval from the DisruptorQueue
> ----------------------------------------------------------------------------
>
>                 Key: STORM-1008
>                 URL: https://issues.apache.org/jira/browse/STORM-1008
>             Project: Apache Storm
>          Issue Type: Sub-task
>            Reporter: Li Wang
>            Assignee: Li Wang
>             Fix For: 0.11.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The code for collecting and retrieving the metrics of the queue is mixed with 
> DisruptorQueue. 
> It is better to isolate metrics collection and retrieval from the 
> implementation of DisruptorQueue, for better extendability and readability of 
> code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to