Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/736#discussion_r39574688
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -30,38 +30,6 @@
<useProjectArtifact>false</useProjectArtifact>
<outputDirectory>lib</outputDirectory>
<unpack>false</unpack>
- <excludes>
--- End diff --
That was one thing what I didn't understand, and it was a sign that we
didn't shade libraries properly.
(Because assembly can see those packages...)
Do I understand correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
