[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746400#comment-14746400 ]
ASF GitHub Bot commented on STORM-1012: --------------------------------------- Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/736#discussion_r39574688 --- Diff: storm-dist/binary/src/main/assembly/binary.xml --- @@ -30,38 +30,6 @@ <useProjectArtifact>false</useProjectArtifact> <outputDirectory>lib</outputDirectory> <unpack>false</unpack> - <excludes> --- End diff -- That was one thing what I didn't understand, and it was a sign that we didn't shade libraries properly. (Because assembly can see those packages...) Do I understand correctly? > Shade Jackson dependency > ------------------------ > > Key: STORM-1012 > URL: https://issues.apache.org/jira/browse/STORM-1012 > Project: Apache Storm > Issue Type: Bug > Reporter: Parth Brahmbhatt > Assignee: Parth Brahmbhatt > Fix For: 0.11.0 > > > Shading jackson dependency. -- This message was sent by Atlassian JIRA (v6.3.4#6332)