[
https://issues.apache.org/jira/browse/STORM-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908254#comment-14908254
]
Robert Joseph Evans commented on STORM-1069:
--------------------------------------------
Sounds good the only change I would make is to add a comment explaining why
diffWithNow can be `< 0` just in case someone else comes along sees it and
decides to "FIX" some broken code.
> Usage of System.currentTimeMillis() in KafkaSpout can create delays
> --------------------------------------------------------------------
>
> Key: STORM-1069
> URL: https://issues.apache.org/jira/browse/STORM-1069
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-kafka
> Reporter: Dmytro Dragan
> Assignee: Dmytro Dragan
> Priority: Trivial
> Labels: newbie
>
> _System.currentTimeMillis()_ returns the current time (wall-clock). Cause of
> this, you can suddenly get too big or even negative duration measured
> operation if between calls _System.currentTimeMillis()_ has changed the time
> (the adjusted time protocol NTP, administrator corrected clock, etc).
> Theoretically, _(now - _lastUpdateMs)_ in 125 line could return negative
> values.
> The better solution is to use _System.nanoTime()_ for measure elapsed time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
