Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/765#discussion_r40801096
--- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
@@ -123,12 +123,13 @@
port (:port worker)
storm-cluster-state (:storm-cluster-state worker)
prev-backpressure-flag @(:backpressure worker)]
- (if executors
- (if (reduce #(or %1 %2) (map #(.get-backpressure-flag %1)
executors))
- (reset! (:backpressure worker) true) ;; at least one
executor has set backpressure
- (reset! (:backpressure worker) false))) ;; no executor has
backpressure set
+ (when executors
+ (reset! (:backpressure worker)
+ (or @(:transfer-backpressure worker)
--- End diff --
This was actually a bug, and I am going to file a JIRA for this. Having it
reuse the worker backpressure flag, made it turn off backpressure too soon in
some cases, and actually have it get stuck off when it should be on in other
cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
