Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/746#discussion_r41087614
--- Diff:
storm-core/src/jvm/backtype/storm/networktopography/DefaultRackDNSToSwitchMapping.java
---
@@ -0,0 +1,39 @@
+package backtype.storm.networktopography;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * This class implements the {@link DNSToSwitchMapping} interface
+ * It returns the DEFAULT_RACK for every host.
+ */
+public final class DefaultRackDNSToSwitchMapping extends
CachedDNSToSwitchMapping {
--- End diff --
I now we borrowed this from Hadoop, and it looks like Hadoop has the same
issue, but we cannot subclass CachedDNSToSwitchMapping to get caching. It does
not work that way. Please either fix CacheDNSToSwitchMapping to actually do
caching when it is a parent class, or remove it all together and have it's
children inherent directly from AbstractDNSToSwitchMapping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
