Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r41366160 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package backtype.storm.scheduler.resource.strategies; + +import java.util.Collection; +import java.util.Map; + +import backtype.storm.scheduler.Topologies; +import backtype.storm.scheduler.ExecutorDetails; +import backtype.storm.scheduler.TopologyDetails; +import backtype.storm.scheduler.WorkerSlot; +import backtype.storm.scheduler.resource.RAS_Node; + +/** + * An interface to for implementing different scheduling strategies for the resource aware scheduling + * In the future stategies will be pluggable + */ +public interface IStrategy { + + public Map<WorkerSlot, Collection<ExecutorDetails>> schedule(TopologyDetails td); --- End diff -- this is either a tab (evil) or 8 spaces. It seems most of this java code has 4 space indents.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---