[ 
https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946537#comment-14946537
 ] 

ASF GitHub Bot commented on STORM-893:
--------------------------------------

Github user erikdw commented on a diff in the pull request:

    https://github.com/apache/storm/pull/746#discussion_r41366483
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/networktopography/DNSToSwitchMapping.java ---
    @@ -0,0 +1,50 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package backtype.storm.networktopography;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * An interface that must be implemented to allow pluggable
    + * DNS-name/IP-address to RackID resolvers.
    + *
    + */
    +public interface DNSToSwitchMapping {
    +  public final static String DEFAULT_RACK = "/default-rack";
    --- End diff --
    
    please use consistent indentation.  The java code in the storm project 
seems to use 4-space indents.  This applies to this file as well as 
AbstractDNSToSwitchMapping.java.  Maybe others that I've missed with all the 
generated code making this a bit hard to read through.


> Resource Aware Scheduling
> -------------------------
>
>                 Key: STORM-893
>                 URL: https://issues.apache.org/jira/browse/STORM-893
>             Project: Apache Storm
>          Issue Type: Umbrella
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Boyang Jerry Peng
>         Attachments: resource_aware_scheduler_api.pdf
>
>
> At Yahoo we have been working on resource aware scheduling in storm, based 
> off of some work done in academia.  This rollup ticket is to track the 
> complete project.  With several sub tasks.  Some that are already done and 
> need to be pushed back, and others that we have not started on yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to