[ https://issues.apache.org/jira/browse/STORM-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946946#comment-14946946 ]
ASF GitHub Bot commented on STORM-1084: --------------------------------------- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/785#discussion_r41397489 --- Diff: storm-core/src/jvm/backtype/storm/validation/ConfigValidation.java --- @@ -0,0 +1,359 @@ +package backtype.storm.validation; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.lang.annotation.Annotation; +import java.lang.reflect.Field; +import java.lang.reflect.InvocationTargetException; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; + +/** + * Created by jerrypeng on 10/1/15. --- End diff -- Please provide a description of the class instead of your name and date. > Improve Storm config validation process to use java annotations instead of > *_SCHEMA format > ------------------------------------------------------------------------------------------ > > Key: STORM-1084 > URL: https://issues.apache.org/jira/browse/STORM-1084 > Project: Apache Storm > Issue Type: Improvement > Components: storm-core > Reporter: Boyang Jerry Peng > Assignee: Boyang Jerry Peng > > So currently we specify validators: > public static final String STORM_MESSAGING_NETTY_MIN_SLEEP_MS = > "storm.messaging.netty.min_wait_ms"; > public static final Object STORM_MESSAGING_NETTY_MIN_SLEEP_MS_SCHEMA = > ConfigValidation.IntegerValidator; > A better way to do this is using annotations. Something like: > @IntegerValidator > public static final String STORM_MESSAGING_NETTY_MIN_SLEEP_MS = > "storm.messaging.netty.min_wait_ms"; > Do this has many advantages. For one you can stack multiple annotations: > @IntegerValidator > @NotNull > public static final String STORM_MESSAGING_NETTY_MIN_SLEEP_MS = > "storm.messaging.netty.min_wait_ms"; > And we don't have to write another validator for strings that cannot be null > And we can pass parameters into the annotations: > @PositiveIntegerValidator(notNull=true) > public static final String DRPC_REQUEST_TIMEOUT_SECS = > "drpc.request.timeout.secs"; > instead of having to write another validator: > ConfigValidation.NotNullPosIntegerValidator for checking for not null -- This message was sent by Atlassian JIRA (v6.3.4#6332)