[
https://issues.apache.org/jira/browse/STORM-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957163#comment-14957163
]
ASF GitHub Bot commented on STORM-350:
--------------------------------------
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/797
STORM-350: Upgrade to newer version of disruptor
This replaces #750 because I rebased.
@HeartSaVioR I think I found the bug that you saw. @kishorvpatil was doing
scale testing and found an NPE issue. There was a race condition when a read
was timing out and I badly tried to read after the timeout instead of just
returning.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm disruptor-upgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/797.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #797
----
commit eda48fc05c5bee2d757ba5f7d48926b45de10b68
Author: Robert (Bobby) Evans <[email protected]>
Date: 2015-09-18T21:33:39Z
STORM-350: Upgrade to newer version of disruptor
commit cb3ca023e96da81fce5c2162598b399383f30f4d
Author: Robert (Bobby) Evans <[email protected]>
Date: 2015-09-23T13:43:41Z
Fixed null reads from disruptor.
commit e6e69b90d75be898b8040bdf3cc1ce76373352e0
Author: Robert (Bobby) Evans <[email protected]>
Date: 2015-09-24T18:45:36Z
Added in an in-order test case.
commit e496d0159297339260f390f5048f2446c1e443a0
Author: Robert (Bobby) Evans <[email protected]>
Date: 2015-10-05T18:50:51Z
Addressed some review comments
commit 59f16a5dd51ffe97e09478f40b80ac47b1e85e95
Author: Robert (Bobby) Evans <[email protected]>
Date: 2015-10-14T15:47:23Z
Fixed issue with disruptor queue timeout. Also updated it to use
AtomicReference so debugging checks can be simpler.
----
> Update disruptor to latest version (3.2.1)
> ------------------------------------------
>
> Key: STORM-350
> URL: https://issues.apache.org/jira/browse/STORM-350
> Project: Apache Storm
> Issue Type: Dependency upgrade
> Components: storm-core
> Reporter: Boris Aksenov
> Assignee: Boris Aksenov
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments:
> 20141117-0.9.3-rc1-3-worker-separate-1-spout-and-2-bolts-failing-tuples.png,
> 20141117-0.9.3-rc1-one-worker-failing-tuples.png,
> 20141117-0.9.3-rc1-three-workers-1-spout-3-bolts-failing-tuples.png,
> 20141118-0.9.3-branch-3-worker-separate-1-spout-and-2-bolts-ok.png,
> 20141118-0.9.3-branch-one-worker-ok.png,
> 20141118-0.9.3-branch-three-workers-1-spout-3-bolts-ok.png, Storm UI1.pdf,
> Storm UI2.pdf, storm-0.9.3-rc1-failing-tuples.png,
> storm-0_9_2-incubating-failing-tuples.png,
> storm-0_9_2-incubating-no-failing-tuples.png,
> storm-failed-tuples-multi-node.png, storm-multi-node-without-350.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
