Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/797#issuecomment-148236995
@revans2
I'm sorry but could you elaborate, please?
NPE could be occurred that we were reading same offset two or more times
since we set offset to null after reading.
I don't know Disruptor deeply, but as far as I understand, I think
consumeBatchWhenAvailable() seems not be thread safe unless _barrier.waitFor()
forces wait for other thread to read datas first, since there're timing issue
between modification of cursor and getting current cursor before calling
_barrier.waitFor().
If consumeBatchWhenAvailable() is not thread-safe, revised consumeBatch()
is not thread-safe, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
