Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/785#issuecomment-148441476
  
    It looks really good. I am +1 for merging this in.  I have one question 
about checking that they type is iterable in one place, and then ignoring the 
error, to have the other code blow up if it is not iterable.  It should do the 
right thing, just the code is confusing and/or unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to