Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r42242430
--- Diff: storm-core/src/storm.thrift ---
@@ -244,8 +244,9 @@ struct CommonAggregateStats {
2: optional i32 num_tasks;
3: optional i64 emitted;
4: optional i64 transferred;
-5: optional i64 acked;
-6: optional i64 failed;
+5: optional double throughput;
+6: optional i64 acked;
+7: optional i64 failed;
--- End diff --
This is another problem with maintaining binary compatibility with the
previous code. You cannot renumber entries. The tags at the beginning are
what identify the field in the binary data. By renumbering them the new code
and old code will mix up throughput, acked, and failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
