[ 
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960699#comment-14960699
 ] 

ASF GitHub Bot commented on STORM-1057:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/753#discussion_r42242476
  
    --- Diff: storm-core/src/storm.thrift ---
    @@ -279,9 +280,10 @@ struct ComponentAggregateStats {
     struct TopologyStats {
     1: optional map<string, i64> window_to_emitted;
     2: optional map<string, i64> window_to_transferred;
    -3: optional map<string, double> window_to_complete_latencies_ms;
    -4: optional map<string, i64> window_to_acked;
    -5: optional map<string, i64> window_to_failed;
    +3: optional map<string, double> window_to_throughput;
    +4: optional map<string, double> window_to_complete_latencies_ms;
    +5: optional map<string, i64> window_to_acked;
    +6: optional map<string, i64> window_to_failed;
    --- End diff --
    
    Here too, we cannot renumber the entires or the thrift code will not be 
compatible with older versions.


> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
>                 Key: STORM-1057
>                 URL: https://issues.apache.org/jira/browse/STORM-1057
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Li Wang
>            Assignee: Li Wang
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance 
> bottleneck of a topology. Displaying the throughputs of components and tasks 
> on the web ui could greatly facilitate the user identifying the performance 
> bottleneck and checking whether the the workload among components and tasks 
> are balanced. 
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to