Github user rtandonmsft commented on a diff in the pull request:
https://github.com/apache/storm/pull/476#discussion_r42408922
--- Diff: bin/storm.cmd ---
@@ -90,6 +90,7 @@
)
set path=%PATH%;%STORM_BIN_DIR%;%STORM_SBIN_DIR%
call start /b "%storm-command%" "%JAVA%" %JAVA_HEAP_MAX% %STORM_OPTS%
%STORM_LOG_FILE% %CLASS% %storm-command-arguments%
+ exit /b %ERRORLEVEL%
goto :eof
--- End diff --
@knusbaum Yes, I do not see any control flow issue of removing or keeping
it with this change. I did not do it to keep the sub routine blocks consistent
so that all end with goto :eof, plus this is an already deployed and working
change in Apache Storm on Azure HDInsight for more than 6 months.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
