[
https://issues.apache.org/jira/browse/STORM-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963797#comment-14963797
]
ASF GitHub Bot commented on STORM-720:
--------------------------------------
Github user rtandonmsft commented on a diff in the pull request:
https://github.com/apache/storm/pull/476#discussion_r42408922
--- Diff: bin/storm.cmd ---
@@ -90,6 +90,7 @@
)
set path=%PATH%;%STORM_BIN_DIR%;%STORM_SBIN_DIR%
call start /b "%storm-command%" "%JAVA%" %JAVA_HEAP_MAX% %STORM_OPTS%
%STORM_LOG_FILE% %CLASS% %storm-command-arguments%
+ exit /b %ERRORLEVEL%
goto :eof
--- End diff --
@knusbaum Yes, I do not see any control flow issue of removing or keeping
it with this change. I did not do it to keep the sub routine blocks consistent
so that all end with goto :eof, plus this is an already deployed and working
change in Apache Storm on Azure HDInsight for more than 6 months.
> Storm.cmd should return ERRORLEVEL before exiting main block
> ------------------------------------------------------------
>
> Key: STORM-720
> URL: https://issues.apache.org/jira/browse/STORM-720
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.9.3, 0.9.4
> Reporter: Ravi Tandon
> Assignee: Ravi Tandon
> Priority: Trivial
> Fix For: 0.9.3, 0.9.4
>
> Attachments: storm_cmd_exitcode_rev0.patch
>
>
> This JIRA is for a very small PR that I will post soon (attached patch)
> Issue: The Storm.cmd does not exit with an ErrorLevel.
> Impact: Any automation via windows banks on return or exit code from the
> program to determine success.
> When can this occur: Passing wrong arguments (like wrong class name or bad
> topology builder code) to java will result in error and any automation
> program will check on the exit code.
> FYI @ [~harsha_ch] [~shanyu]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
