Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/807#discussion_r42669817
  
    --- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
    @@ -1215,6 +1254,7 @@
          * to be equal to the number of workers configured for this topology. 
If this variable is set to 0,
          * event logging will be disabled.</p>
          */
    +    @isPositiveNumber
    --- End diff --
    
    This is a really minor nit, but everywhere else `@isInteger` is above 
`@isPositiveNumber` it would be nice to be consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to