[
https://issues.apache.org/jira/browse/STORM-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970021#comment-14970021
]
ASF GitHub Bot commented on STORM-1125:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/813#discussion_r42814836
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -54,6 +54,10 @@
(when (Utils/isZkAuthenticationConfiguredTopology topo-conf)
[(first ZooDefs$Ids/CREATOR_ALL_ACL)
(ACL. ZooDefs$Perms/READ (Id. "digest"
(DigestAuthenticationProvider/generateDigest payload)))])))
+
+(defn is-nimbus?
--- End diff --
How about removing this and let the caller of mk-distributed-cluster-state
decides whether writer and reader should be separated? (I mean additional
argument or multimethod.)
I think it can achieve loose coupling since ClusterState doesn't need to
know current daemon is nimbus or not. It just wants to know whether writer and
reader should be separated or not.
> Separate ZK Write Client for Nimbus
> -----------------------------------
>
> Key: STORM-1125
> URL: https://issues.apache.org/jira/browse/STORM-1125
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Kishor Patil
> Assignee: Kishor Patil
>
> Given the amount of reads from ZK by nimbus, shared ZK connections for write
> quickly starts overwhelm single connection blocking writes without any
> dependence.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
