[
https://issues.apache.org/jira/browse/STORM-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984093#comment-14984093
]
ASF GitHub Bot commented on STORM-1145:
---------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/830#discussion_r43574714
--- Diff: storm-core/src/clj/backtype/storm/disruptor.clj ---
@@ -27,10 +27,10 @@
:single-threaded ProducerType/SINGLE})
(defnk disruptor-queue
- [^String queue-name buffer-size timeout :producer-type :multi-threaded]
+ [^String queue-name buffer-size timeout :producer-type :multi-threaded
:batch-size 100 :batch-timeout 1]
--- End diff --
can we make these default batch-size values come from config
> Have the IConnection push batches instead of buffering them
> -----------------------------------------------------------
>
> Key: STORM-1145
> URL: https://issues.apache.org/jira/browse/STORM-1145
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> The messaging layer currently buffers tuples and waits for one or more
> threads to take the tuples and route them where they need to go.
> This adds an extra thread that a tuple has to go through before it can be
> processed, and places the tuple in a LinkedBlockingQueue waiting for one of
> the threads to be ready to process the data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
