Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r43813101
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -1103,21 +1216,39 @@
(.set_reset_log_level_timeout_epoch log-config (coerce/to-long
timeout))
(.unset_reset_log_level_timeout_epoch log-config))))
+(defmethod blob-sync-code :distributed [conf nimbus]
+ (if (not (is-leader nimbus :throw-exception false))
+ (let [storm-cluster-state (:storm-cluster-state nimbus)
+ nimbus-host-port-info (:nimbus-host-port-info nimbus)
+ blob-store-key-list (get-key-list-from-blob-store (:blob-store
nimbus))
+ zk-key-list (into [] (.blobstore storm-cluster-state (fn []
(blob-sync-code conf nimbus))))]
+ (log-debug "blob-sync-code " "keys " blob-store-key-list "blob-key "
blob-store-key-list)
+ (let [sync-object (doto
+ (SyncBlobs. (:blob-store nimbus) conf)
+ (.setNimbusInfo nimbus-host-port-info)
+ (.setBlobStoreKeyList (if (not-nil?
blob-store-key-list) (java.util.ArrayList. blob-store-key-list)
(java.util.ArrayList.)))
+ (.setZookeeperKeyList (if (not-nil? zk-key-list)
(java.util.ArrayList. zk-key-list) (java.util.ArrayList.))))]
--- End diff --
Minor, but I think we should import java util ArrayList instead of
repeating complete qualified name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
