[ 
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988324#comment-14988324
 ] 

ASF GitHub Bot commented on STORM-876:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/845#issuecomment-153511977
  
    @ptgoetz I don't consider this criticism and I'm not really trying to 
complain, I'm just trying to understand what requires an IP grant. 
    
    from http://incubator.apache.org/ip-clearance/index.html I find
    
    >  From time to time, an external codebase is brought into the ASF that is 
not a separate incubating project but still represents a substantial 
contribution that was not developed within the ASF's source control system and 
on our public mailing lists.
    
    and
    
    > The intent is to simply help to ensure, and record, that due diligence 
(Software Grant, CLA, Corp CLA, license and dependencies) has been paid to the 
incoming code, so that it can be merged into an existing project/module.
    
    Which seems a lot more vague than
    
    >   * Was the code developed in the open, using ASF infrastructure?
    >   * Was the Apache community aware of its existence from inception, or 
early on, such that it could contribute to it’s development?
    >   * Is the commit history intact such that all contributors can be 
identified?
    
    I can also see how these map from one to the other but not totally.  I am 
mostly confused about what is "a substantial contribution" which I am not 
disputing this is.  I am also confused about how putting a large pull request 
up differs from this?  Even though the core of this was developed in a separate 
repository anything and everything in this pull request is up for modification 
if the community feels that we need to.  The design document has been up for 
over a week, and the JIRA itself has been open since June that no one touched 
until now, but could have.  And most of the code has been touched in preparing 
it to work with Nimbus HA, specifically for this.  Lastly I don't see a reason 
to have the code contribution be attributed line by line, if we call out 
exactly who helped contribute to the patch.
    
    If you feel that we need an IP Grant for this I will make it happen, but 
going forward we the PMC need to have a discussion and clarify these questions, 
because to me leaving this up to a gut feeling is just going to put up too many 
barriers and potential frustration for developers.  Now I don't want line 
counts or anything like that, but something a lot less vague than "substantial"


> Dist Cache: Basic Functionality
> -------------------------------
>
>                 Key: STORM-876
>                 URL: https://issues.apache.org/jira/browse/STORM-876
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and 
> downloading dist cache items.  storm-core.ser, storm-conf.ser and storm.jar 
> should be written into the blob store instead of residing locally. We need a 
> default implementation of the blob store that does essentially what nimbus 
> currently does and does not need anything extra.  But having an HDFS backend 
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and 
> provide a working directory for the worker process with symlinks to the 
> blobs.  It should also allow the blobs to be updated and switch the symlink 
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process 
> of getting it ready to push back to open source shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to