Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/855#issuecomment-154085743
I when through the code in more detail and I had a few minor nits, but also
a few issues that I am concerned about.
Primarily error handling when using a separate thread for timed expiry. But
fundamentally I am concerned that the windowing functionality assumes that
arrival time to the bolt is the only time that people will want to do windowed
intervals over, which is just not true.
This potentially opens up a whole can of worms the more I think about it,
and I am not sure that this is the best way to do windowing at scale if we want
to be able to support late data, out of order arrival, and event creation time
as a part of the window.
Additionally I would like to see more documentation about how to use this
functionality, not just a simple example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
