[
https://issues.apache.org/jira/browse/STORM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991771#comment-14991771
]
ASF GitHub Bot commented on STORM-1167:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/855#issuecomment-154085743
I when through the code in more detail and I had a few minor nits, but also
a few issues that I am concerned about.
Primarily error handling when using a separate thread for timed expiry. But
fundamentally I am concerned that the windowing functionality assumes that
arrival time to the bolt is the only time that people will want to do windowed
intervals over, which is just not true.
This potentially opens up a whole can of worms the more I think about it,
and I am not sure that this is the best way to do windowing at scale if we want
to be able to support late data, out of order arrival, and event creation time
as a part of the window.
Additionally I would like to see more documentation about how to use this
functionality, not just a simple example.
> Add sliding & tumbling window support for core storm
> ----------------------------------------------------
>
> Key: STORM-1167
> URL: https://issues.apache.org/jira/browse/STORM-1167
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
>
> Currently, topologies that needs windowing support requires writing custom
> logic inside bolts making it tedious to handle the windowing and acking logic
> with custom logic.
> We can add framework level support to core storm bolts to process tuples in a
> time or a count based window. Sliding and tumbling windows can be supported.
> Later this can be extended to trident apis as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
