Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/871#discussion_r44597850
  
    --- Diff: 
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
    @@ -56,9 +56,9 @@
         private ExecutorService callTimeoutPool;
         private transient Timer heartBeatTimer;
         private Boolean kerberosEnabled = false;
    -    private AtomicBoolean timeToSendHeartBeat = new AtomicBoolean(false);
    +    private Boolean sendHeartBeat = true;
    --- End diff --
    
    I think this needs to be volatile or atomic.  It is written in one thread 
and read in another with no locks around any of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to