Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/532#issuecomment-156038940
@revans2
This PR improves subprocess to request ShellBolt for back pressure, but I
left decision when to request to users since I thought it is more flexible.
If we want to provide default, sure we can have default condition for
requesting back-pressure via high/low watermark (like ABP).
Btw, we now have ABP, which seems not compatible to ShellBolt.
ShellBolt just receives tuples from Disruptor Queue and pass to subprocess
whether subprocess is busy or not. In result size of the receive queue doesn't
nearly reach high watermark.
One idea to make ShellSpout be compatible to ABP is, changing
implementation of ShellBolt to sync (like ShellSpout).
Expected downside is it may hurt performance, but it is actually more
natural flow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
