Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/875#discussion_r45129773
--- Diff: storm-core/src/ui/public/index.html ---
@@ -143,6 +143,12 @@
]
});
$('#topology-summary [data-toggle="tooltip"]').tooltip();
+ $.getJSON("/api/v1/cluster/configuration", function(json){
+ var displayResource = json["scheduler.display.resource"];
+ if (!displayResource){
+ $('#topology-summary td:nth-child(10),#topology-summary
th:nth-child(10)').hide();
--- End diff --
I tried to pass "schedulerDisplayResource" to each supervisor-summary and
topology-summary in REST and then use this to check whether we want to display
in template htmls. However, it seems a little weird to store a cluster-wide
configuration as a supervisor-specific or topology-specific field. Also, when
there is no topology submitted, it is not feasible to check whether we want to
display the assignedCPU in the topology-summary table's header (similarly for
supervisor summary table).
We may rather keep it still since later we will have RAS as default
scheduler and will merge with JSTORM's UI features.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
