Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/884#issuecomment-157749683
Thanks for the contribution, any reason you decided to make this hook part
of serialized topology. If you see some other examples, like the nimbus hook
(though it is not really a great example as its on nimbus side and not worker
but still close) we ask the user to just provide the Fully qualified classname
as a config option, create an instance of it using reflection and invoke
prepare (start in your case) or cleanup on that instance. The only advantage of
putting this as part of topology is that users will be able to provide objects
that are completely serialized so it can be initialized with constructor args
or with any other way that relies on instance variable initialization but I
don't see that as a huge upside. On the other hand a consistent way to
implement all hooks will make code easy to read and reason about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
