[
https://issues.apache.org/jira/browse/STORM-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011555#comment-15011555
]
ASF GitHub Bot commented on STORM-904:
--------------------------------------
Github user priyank5485 commented on the pull request:
https://github.com/apache/storm/pull/662#issuecomment-157804563
@hustfxj I might have missed something and its been a long time since i
did this. I could not find any storm command that would not need a waitFor. Can
you give an example? If we do need that flag it should be easy to add and I can
change that.
@longdafeng I am not sure I understand the point about debugging. You can
still put a break point in this java version of storm command line. I agree
with you that its easier to write new functions in script. But the whole point
of this JIRA is to have one client that works for Unix based systems and
Windows platform. The last time I was working on it we had storm.py for Unix
and storm batch client for windows. Both of them also had a separate file for
environment variables. It is hard to maintain two scripts anytime we want to
change the storm command. We can ask others about their opinion and what they
think is better between the two approaches.
> move storm bin commands to java and provide appropriate bindings for windows
> and linux
> --------------------------------------------------------------------------------------
>
> Key: STORM-904
> URL: https://issues.apache.org/jira/browse/STORM-904
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Sriharsha Chintalapani
> Assignee: Priyank Shah
>
> Currently we have python and .cmd implementation for windows. This is
> becoming increasing difficult upkeep both versions. Lets make all the main
> code of starting daemons etc. to java and provider wrapper scripts in shell
> and batch for linux and windows respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
