[
https://issues.apache.org/jira/browse/STORM-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011921#comment-15011921
]
ASF GitHub Bot commented on STORM-1213:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/887#discussion_r45257261
--- Diff: external/storm-metrics/pom.xml ---
@@ -48,6 +48,13 @@
</exclusions>
</dependency>
<dependency>
+ <groupId>org.fusesource</groupId>
+ <artifactId>sigar</artifactId>
+ <version>1.6.4</version>
--- End diff --
We should also make this version a property or set in the parent pom,
because there are multiple packages tied to this same version. And we should
remove the comment on line 39, as it is not needed.
> Remove sigar binaries from source tree
> --------------------------------------
>
> Key: STORM-1213
> URL: https://issues.apache.org/jira/browse/STORM-1213
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.11.0
> Reporter: P. Taylor Goetz
> Assignee: P. Taylor Goetz
>
> In {{external/storm-metrics}} sigar native binaries were added to the source
> tree. Since Apache releases are source-only, these binaries can't be included
> in a release.
> My initial thought was just to exclude the binaries from the source
> distribution, but that would mean that distributions built from a source
> tarball would not match the convenience binaries from a release (the sigar
> native binaries would not be included.
> The solution I came up with was to leverage the fact that pre-built native
> binaries are included in the sigar maven distribution
> ({{sigar-x.x.x-native.jar}}) and use the maven dependency plugin to unpack
> them into place during the build, rather than check them into git. One
> benefit is that it will ensure the versions of the sigar jar and the native
> binaries match. Another is that mavens checksum/signature checking mechanism
> will also be applied.
> This isn't an ideal solution since the {{sigar-x.x.x-native.jar}} only
> includes binaries for linux, OSX, and solaris (notably missing windows DLLs),
> whereas the non-maven sigar download includes support for a wider range of
> OSes and architectures.
> I view this as an interim measure until we can find a better way to include
> the native binaries in the build process, rather than checking them into the
> source tree -- which would be a blocker for releasing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
