Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/845#discussion_r45262960
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -732,25 +863,89 @@
      (if (conf SUPERVISOR-RUN-WORKER-AS-USER)
       (worker-launcher-and-wait conf (storm-conf TOPOLOGY-SUBMITTER-USER) 
["code-dir" dir] :log-prefix (str "setup conf for " dir))))
     
    +(defn setup-blob-permission [conf storm-conf path]
    +  (if (conf SUPERVISOR-RUN-WORKER-AS-USER)
    +    (worker-launcher-and-wait conf (storm-conf TOPOLOGY-SUBMITTER-USER) 
["blob" path] :log-prefix (str "setup blob permissions for " path))))
    +
    +(defn setup-storm-code-dir [conf storm-conf dir]
    +  (if (conf SUPERVISOR-RUN-WORKER-AS-USER)
    +    (worker-launcher-and-wait conf (storm-conf TOPOLOGY-SUBMITTER-USER) 
["code-dir" dir] :log-prefix (str "setup conf for " dir))))
    --- End diff --
    
    * Param list should be on its own line
    * This is the second place we define `setup-storm-code-dir`.  Probably a 
merge error.  They are the same, except this second copy has proper 2-space 
indentation instead of 1-space.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to