[ 
https://issues.apache.org/jira/browse/STORM-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013812#comment-15013812
 ] 

ASF GitHub Bot commented on STORM-1075:
---------------------------------------

Github user fhussonnois commented on a diff in the pull request:

    https://github.com/apache/storm/pull/827#discussion_r45364971
  
    --- Diff: 
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/executor/AsyncExecutor.java
 ---
    @@ -0,0 +1,152 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.storm.cassandra.executor;
    +
    +import com.datastax.driver.core.ResultSet;
    +import com.datastax.driver.core.ResultSetFuture;
    +import com.datastax.driver.core.Session;
    +import com.datastax.driver.core.Statement;
    +import com.google.common.util.concurrent.*;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.Serializable;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.ConcurrentHashMap;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +
    +/**
    + * Service to asynchronously executes cassandra statements.
    + */
    +public class AsyncExecutor<T> implements Serializable {
    +
    +    private final static Logger LOG = 
LoggerFactory.getLogger(AsyncExecutor.class);
    +
    +    protected Session session;
    +
    +    protected ExecutorService executorService;
    +
    +    protected AsyncResultHandler<T> handler;
    +
    +    private Map<SettableFuture<T>, Boolean> pending = new 
ConcurrentHashMap<>( );
    +
    +    /**
    +     * Creates a new {@link AsyncExecutor} instance.
    +     */
    +    protected AsyncExecutor(Session session, AsyncResultHandler<T> 
handler) {
    +        this(session, newSingleThreadExecutor(), handler);
    +    }
    +
    +    /**
    +     * Creates a new {@link AsyncExecutor} instance.
    +     *
    +     * @param session The cassandra session.
    +     * @param executorService The executor service responsible to execute 
handler.
    +     */
    +    private AsyncExecutor(Session session, ExecutorService 
executorService, AsyncResultHandler<T> handler) {
    +        this.session   = session;
    +        this.executorService = executorService;
    +        this.handler = handler;
    +    }
    +
    +    protected static ExecutorService newSingleThreadExecutor() {
    +        return Executors.newSingleThreadExecutor(new 
ThreadFactoryBuilder().setNameFormat("cassandra-async-handler-%d").build());
    +    }
    +
    +    /**
    +     * Asynchronously executes all statements associated to the specified 
input. The input will be passed to
    +     * the {@link #handler} once all queries succeed or failed.
    --- End diff --
    
    Yes there is an issue on the comment. This behavior is implemented with 
    
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/Futures.html#allAsList(java.lang.Iterable)


> Storm Cassandra connector
> -------------------------
>
>                 Key: STORM-1075
>                 URL: https://issues.apache.org/jira/browse/STORM-1075
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Sriharsha Chintalapani
>            Assignee: Satish Duggana
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to