Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r45427569 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java --- @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package backtype.storm.blobstore; + +import backtype.storm.nimbus.NimbusInfo; +import backtype.storm.utils.Utils; +import org.apache.curator.framework.CuratorFramework; +import org.apache.zookeeper.CreateMode; +import org.apache.zookeeper.ZooDefs; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.TreeSet; +import java.util.Map; +import java.util.List; + +/** + * Class hands over the version of the key to be stored within the zookeeper + */ +public class KeyVersion { + private static final Logger LOG = LoggerFactory.getLogger(Utils.class); + private final String BLOBSTORE_SUBTREE="/blobstore"; + private final String BLOBSTORE_KEY_COUNTER_SUBTREE="/blobstorekeycounter"; + private String key; + private NimbusInfo nimbusInfo; + + public KeyVersion(String key, NimbusInfo nimbusInfo) { + this.key = key; + this.nimbusInfo = nimbusInfo; + } + + public int getKeyVersion(Map conf) { + TreeSet<Integer> versions = new TreeSet<Integer>(); + CuratorFramework zkClient = Utils.createZKClient(conf); + try { + // Key has not been created yet and it is the first time it is being created + if(zkClient.checkExists().forPath(BLOBSTORE_SUBTREE + "/" + key) == null) { + zkClient.create().creatingParentsIfNeeded().withMode(CreateMode.PERSISTENT) + .withACL(ZooDefs.Ids.OPEN_ACL_UNSAFE).forPath(BLOBSTORE_KEY_COUNTER_SUBTREE + "/" + key + "/" + 1); --- End diff -- `+ "/1");`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---