Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/894#discussion_r45435067
--- Diff: external/storm-kafka/src/jvm/storm/kafka/StringScheme.java ---
@@ -20,21 +20,23 @@
import backtype.storm.spout.Scheme;
import backtype.storm.tuple.Fields;
import backtype.storm.tuple.Values;
+import backtype.storm.utils.Utils;
import java.io.UnsupportedEncodingException;
+import java.nio.ByteBuffer;
import java.util.List;
public class StringScheme implements Scheme {
public static final String STRING_SCHEME_KEY = "str";
- public List<Object> deserialize(byte[] bytes) {
+ public List<Object> deserialize(ByteBuffer bytes) {
return new Values(deserializeString(bytes));
}
- public static String deserializeString(byte[] string) {
+ public static String deserializeString(ByteBuffer string) {
try {
- return new String(string, "UTF-8");
+ return new String(Utils.toByteArray(string), "UTF-8");
--- End diff --
This would create a copy. If the ByteBuffer is array backed, you could use
`ByteBuffer.array()` to avoid copy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
