Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/875#discussion_r45508355
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
    @@ -764,5 +778,30 @@ public static long zipFileSize(File myFile) throws 
IOException{
         public static double zeroIfNaNOrInf(double x) {
             return (Double.isNaN(x) || Double.isInfinite(x)) ? 0.0 : x;
         }
    +
    +    /**
    +     * parses the arguments to extract jvm heap memory size.
    +     * @param input
    +     * @param defaultValue
    +     * @return the value of the JVM heap memory setting in a java command.
    +     */
    +    public static Double parseWorkerChildOpts(String input, Double 
defaultValue) {
    --- End diff --
    
    I would prefer to have the name of this function indicate what it is 
parsing out of the childopts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to