[ 
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018646#comment-15018646
 ] 

ASF GitHub Bot commented on STORM-885:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/838#discussion_r45510058
  
    --- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
    @@ -778,6 +792,47 @@
         public static final String UI_HTTPS_NEED_CLIENT_AUTH = 
"ui.https.need.client.auth";
     
         /**
    +     * The host that Pacemaker is running on.
    +     */
    +    @isString
    +    public static final String PACEMAKER_HOST = "pacemaker.host";
    +
    +    /**
    +     * The port Pacemaker should run on. Clients should
    +     * connect to this port to submit or read heartbeats.
    +     */
    +    @isNumber
    +    @isPositiveNumber
    +    public static final String PACEMAKER_PORT = "pacemaker.port";
    +
    +    /**
    +     * The maximum number of threads that should be used by the Pacemaker.
    +     * When Pacemaker gets loaded it will spawn new threads, up to 
    +     * this many total, to handle the load.
    +     */
    +    @isNumber
    +    @isPositiveNumber
    +    public static final String PACEMAKER_MAX_THREADS = 
"pacemaker.max.threads";
    +
    +    /**
    +     * This parameter is used by the storm-deploy project to configure the
    +     * jvm options for the pacemaker daemon.
    +     */
    +    @isString
    +    public static final String PACEMAKER_CHILDOPTS = "pacemaker.childopts";
    +
    +    /**
    +     * This should be one of "DIGEST", "KERBEROS", or "NONE"
    +     * Determines the mode of authentication the pacemaker server and 
client use.
    +     * The client must either match the server, or be NONE. In the case of 
NONE,
    +     * no authentication is performed for the client, and if the server is 
running with
    +     * DIGEST or KERBEROS, the client can only write to the server (no 
reads).
    +     * This is intended to provide a primitive form of access-control.
    +     */
    +    @isString
    +    public static final String PACEMAKER_AUTH_METHOD = 
"pacemaker.auth.method";
    --- End diff --
    
    It would be nice to have a validator that explicitly tests the value beyond 
its type, but we have other configs that do the same thing.  If it becomes an 
issue, we can create a validator as part of another jira.


> Heartbeat Server (Pacemaker)
> ----------------------------
>
>                 Key: STORM-885
>                 URL: https://issues.apache.org/jira/browse/STORM-885
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Kyle Nusbaum
>
> Large highly connected topologies and large clusters write a lot of data into 
> ZooKeeper.  The heartbeats, that make up the majority of this data, do not 
> need to be persisted to disk.  Pacemaker is intended to be a secure 
> replacement for storing the heartbeats without changing anything within the 
> heartbeats.  In the future as more metrics are added in, we may want to look 
> into switching it over to look more like Heron, where a metrics server is 
> running for each node/topology.  And can be used to aggregate/per-aggregate 
> them in a more scalable manor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to