[
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018725#comment-15018725
]
ASF GitHub Bot commented on STORM-885:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45514952
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/SaslStormServerHandler.java
---
@@ -136,17 +135,19 @@ public void messageReceived(ChannelHandlerContext
ctx, MessageEvent e)
@Override
public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent
e) {
- server.closeChannel(e.getChannel());
+ if(server != null) server.closeChannel(e.getChannel());
}
private void getSASLCredentials() throws IOException {
- topologyName = (String) this.server.storm_conf
- .get(Config.TOPOLOGY_NAME);
- String secretKey = SaslUtils.getSecretKey(this.server.storm_conf);
+ String secretKey;
+ topologyName = server.name();
+ secretKey = server.secretKey();
+
if (secretKey != null) {
token = secretKey.getBytes();
}
+
LOG.debug("SASL credentials for storm topology " + topologyName
- + " is " + secretKey);
+ + " is " + secretKey);
--- End diff --
Let's use format strings in this log message so we don't construct strings
every time.
> Heartbeat Server (Pacemaker)
> ----------------------------
>
> Key: STORM-885
> URL: https://issues.apache.org/jira/browse/STORM-885
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Kyle Nusbaum
>
> Large highly connected topologies and large clusters write a lot of data into
> ZooKeeper. The heartbeats, that make up the majority of this data, do not
> need to be persisted to disk. Pacemaker is intended to be a secure
> replacement for storing the heartbeats without changing anything within the
> heartbeats. In the future as more metrics are added in, we may want to look
> into switching it over to look more like Heron, where a metrics server is
> running for each node/topology. And can be used to aggregate/per-aggregate
> them in a more scalable manor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
