[
https://issues.apache.org/jira/browse/STORM-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026184#comment-15026184
]
ASF GitHub Bot commented on STORM-1341:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/903
STORM-1341 Let topology have own heartbeat timeout for multilang subprocess
* config name: topology.subprocess.timeout.secs
* if it's not specified, supervisor.worker.timeout.secs will be used
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1341
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #903
----
commit fc8c296efc41c1efc6060ba09c07d406ceacc844
Author: Jungtaek Lim <[email protected]>
Date: 2015-11-25T04:46:59Z
STORM-1341 Let topology have own heartbeat timeout for multilang subprocess
* config name: topology.subprocess.timeout.secs
* if it's not specified, supervisor.worker.timeout.secs will be used
----
> Better to have multilang subprocess timeout, not relying on supervisor worker
> timeout
> -------------------------------------------------------------------------------------
>
> Key: STORM-1341
> URL: https://issues.apache.org/jira/browse/STORM-1341
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-multilang
> Reporter: Jungtaek Lim
> Priority: Minor
>
> Currently, ShellBolt determines that subprocess is hang if there're no
> message from subprocess within SUPERVISOR_WORKER_TIMEOUT_SECS.
> Since ShellBolt treats all kinds of message to heartbeat (STORM-742), we get
> rid of heartbeat issue that heartbeat tuple cannot processed in time because
> too many other BoltMsgs waiting.
> But it doesn't cover two scenario,
> - STORM-758: Subprocess doesn't send anything - emit, ack, fail - so
> ShellBolt has to rely on heartbeat tuple. It is valid for non-ACK mode.
> - Each (or some kind of) tuple takes very long time to process. For now it
> should be shorter than SUPERVISOR_WORKER_TIMEOUT_SECS.
> It could be better to have multilang subprocess timeout for clarity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
