[ 
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038241#comment-15038241
 ] 

ASF GitHub Bot commented on STORM-876:
--------------------------------------

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/845#issuecomment-161736488
  
    @redsanket First of all thank you for contributing this and making it 
through the most epic code review we've had to date. :)
    
    I'm +1 for merging this as is, but I'd like to see two follow up tasks (can 
be handled as separate JIRAs):
    
    1. Merge the contents of the DISTCACHE.md and design document attached to 
the JIRA and add them to Storm's documentation.
    2. Add an example topology to storm-starter (e.g. one with a bolt that uses 
the blobstore to lookup values from a sample file, etc. that may change over 
time).
    
    We should probably address those 2 items before a 1.0 release.
    
    This is a big addition. I'd encourage other committers to review this as 
well, if for no other reason than to familiarize yourself with the 
functionality that's being added.


> Dist Cache: Basic Functionality
> -------------------------------
>
>                 Key: STORM-876
>                 URL: https://issues.apache.org/jira/browse/STORM-876
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and 
> downloading dist cache items.  storm-core.ser, storm-conf.ser and storm.jar 
> should be written into the blob store instead of residing locally. We need a 
> default implementation of the blob store that does essentially what nimbus 
> currently does and does not need anything extra.  But having an HDFS backend 
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and 
> provide a working directory for the worker process with symlinks to the 
> blobs.  It should also allow the blobs to be updated and switch the symlink 
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process 
> of getting it ready to push back to open source shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to