[ https://issues.apache.org/jira/browse/STORM-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043497#comment-15043497 ]
ASF GitHub Bot commented on STORM-1187: --------------------------------------- Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/900#discussion_r46762681 --- Diff: storm-core/src/jvm/backtype/storm/windowing/TimeEvictionPolicy.java --- @@ -21,21 +21,30 @@ * Eviction policy that evicts events based on time duration. */ public class TimeEvictionPolicy<T> implements EvictionPolicy<T> { - private final long duration; + private final int windowLength; + protected Long currentTs; --- End diff -- Its the reference time for the window calculation, based on which events are expired from the window. Will rename to `referenceTime`. > Support for late and out of order events in time based windows > -------------------------------------------------------------- > > Key: STORM-1187 > URL: https://issues.apache.org/jira/browse/STORM-1187 > Project: Apache Storm > Issue Type: Sub-task > Reporter: Arun Mahadevan > Assignee: Arun Mahadevan > > Right now the time based windows uses the timestamp when the tuple is > received by the bolt. > However there are use cases where the tuples can be processed based on the > time when they are actually generated vs the time when they are received. So > we need to add support for processing events with a time lag and also have > some way to specify and read tuple timestamps. -- This message was sent by Atlassian JIRA (v6.3.4#6332)