Derek Dagit created STORM-1377:
----------------------------------

             Summary: nimbus_auth_test: some tests may access the wrong nimbus 
test node 
                 Key: STORM-1377
                 URL: https://issues.apache.org/jira/browse/STORM-1377
             Project: Apache Storm
          Issue Type: Bug
            Reporter: Derek Dagit
            Priority: Minor


A race condition may lead certain tests to fail in the nimbus-auth-test 
namespace.

{noformat}
Running backtype.storm.security.auth.nimbus-auth-test

75777 [pool-475-thread-1] INFO  b.s.l.ThriftAccessLogger - Request ID: 6 access 
from:  principal:  operation: submitTopology

75780 [pool-475-thread-1] WARN  b.s.d.nimbus - Topology submission exception. 
(topology name='topo-name') #error {

 :cause nil

 :via

 [{:type backtype.storm.generated.AuthorizationException

   :message nil

   :at [backtype.storm.daemon.nimbus$check_authorization_BANG_ invoke 
nimbus.clj 935]}]

 :trace

 [[backtype.storm.daemon.nimbus$check_authorization_BANG_ invoke nimbus.clj 935]

  [backtype.storm.daemon.nimbus$check_authorization_BANG_ invoke nimbus.clj 938]

  [backtype.storm.daemon.nimbus$fn__7019$exec_fn__3205__auto__$reify__7048 
submitTopologyWithOpts nimbus.clj 1328]

  [backtype.storm.daemon.nimbus$fn__7019$exec_fn__3205__auto__$reify__7048 
submitTopology nimbus.clj 1401]

  [backtype.storm.generated.Nimbus$Processor$submitTopology getResult 
Nimbus.java 2014]

  [backtype.storm.generated.Nimbus$Processor$submitTopology getResult 
Nimbus.java 1998]

  [org.apache.thrift.ProcessFunction process ProcessFunction.java 39]

  [org.apache.thrift.TBaseProcessor process TBaseProcessor.java 39]

  [backtype.storm.security.auth.SimpleTransportPlugin$SimpleWrapProcessor 
process SimpleTransportPlugin.java 158]

  [org.apache.thrift.server.AbstractNonblockingServer$FrameBuffer invoke 
AbstractNonblockingServer.java 518]

  [org.apache.thrift.server.Invocation run Invocation.java 18]

  [java.util.concurrent.ThreadPoolExecutor runWorker ThreadPoolExecutor.java 
1142]

  [java.util.concurrent.ThreadPoolExecutor$Worker run ThreadPoolExecutor.java 
617]

  [java.lang.Thread run Thread.java 745]]}

75956 [Thread-191-spout-executor[8 8]-EventThread] WARN  o.a.c.ConnectionState 
- Session expired event received

75959 [Thread-191-spout-executor[8 8]-EventThread] INFO  
o.a.c.f.s.ConnectionStateManager - State change: LOST

75984 [pool-475-thread-2] INFO  b.s.l.ThriftAccessLogger - Request ID: 7 access 
from:  principal:  operation: submitTopology

75984 [pool-475-thread-2] WARN  b.s.d.nimbus - Topology submission exception. 
(topology name='topo-name') #error {

 :cause nil

 :via

 [{:type backtype.storm.generated.AuthorizationException

   :message nil

   :at [backtype.storm.daemon.nimbus$check_authorization_BANG_ invoke 
nimbus.clj 935]}]

 :trace

 [[backtype.storm.daemon.nimbus$check_authorization_BANG_ invoke nimbus.clj 935]

  [backtype.storm.daemon.nimbus$check_authorization_BANG_ invoke nimbus.clj 938]

  [backtype.storm.daemon.nimbus$fn__7019$exec_fn__3205__auto__$reify__7048 
submitTopologyWithOpts nimbus.clj 1328]

  [backtype.storm.generated.Nimbus$Processor$submitTopologyWithOpts getResult 
Nimbus.java 2042]

  [backtype.storm.generated.Nimbus$Processor$submitTopologyWithOpts getResult 
Nimbus.java 2026]

  [org.apache.thrift.ProcessFunction process ProcessFunction.java 39]

  [org.apache.thrift.TBaseProcessor process TBaseProcessor.java 39]

  [backtype.storm.security.auth.SimpleTransportPlugin$SimpleWrapProcessor 
process SimpleTransportPlugin.java 158]

  [org.apache.thrift.server.AbstractNonblockingServer$FrameBuffer invoke 
AbstractNonblockingServer.java 518]

  [org.apache.thrift.server.Invocation run Invocation.java 18]

  [java.util.concurrent.ThreadPoolExecutor runWorker ThreadPoolExecutor.java 
1142]

  [java.util.concurrent.ThreadPoolExecutor$Worker run ThreadPoolExecutor.java 
617]

  [java.lang.Thread run Thread.java 745]]}

75989 [Thread-191-spout-executor[8 8]-EventThread] INFO  
o.a.c.f.s.ConnectionStateManager - State change: RECONNECTED

76006 [pool-475-thread-3] INFO  b.s.l.ThriftAccessLogger - Request ID: 8 access 
from:  principal:  operation: fileUpload

76044 [pool-475-thread-4] INFO  b.s.l.ThriftAccessLogger - Request ID: 9 access 
from:  principal:  operation: fileUpload

76049 [pool-475-thread-5] INFO  b.s.l.ThriftAccessLogger - Request ID: 10 
access from:  principal:  operation: fileUpload

76054 [pool-475-thread-1] INFO  b.s.l.ThriftAccessLogger - Request ID: 6 access 
from:  principal:  operation: fileDownload

76059 [pool-475-thread-2] INFO  b.s.l.ThriftAccessLogger - Request ID: 7 access 
from:  principal:  operation: fileDownload

76063 [pool-475-thread-3] INFO  b.s.l.ThriftAccessLogger - Request ID: 8 access 
from:  principal:  operation: getNimbusConf

76068 [pool-475-thread-4] INFO  b.s.l.ThriftAccessLogger - Request ID: 9 access 
from:  principal:  operation: getClusterInfo

76074 [pool-475-thread-5] INFO  b.s.l.ThriftAccessLogger - Request ID: 10 
access from:  principal:  operation: killTopology

76087 [pool-475-thread-1] INFO  b.s.l.ThriftAccessLogger - Request ID: 6 access 
from:  principal:  operation: killTopology

76088 [pool-475-thread-2] INFO  b.s.l.ThriftAccessLogger - Request ID: 7 access 
from:  principal:  operation: activate

76093 [pool-475-thread-3] INFO  b.s.l.ThriftAccessLogger - Request ID: 8 access 
from:  principal:  operation: deactivate

76098 [pool-475-thread-4] INFO  b.s.l.ThriftAccessLogger - Request ID: 9 access 
from:  principal:  operation: rebalance

76103 [pool-475-thread-5] INFO  b.s.l.ThriftAccessLogger - Request ID: 10 
access from:  principal:  operation: getTopologyConf

76109 [pool-475-thread-1] INFO  b.s.l.ThriftAccessLogger - Request ID: 6 access 
from:  principal:  operation: getTopology

76114 [pool-475-thread-2] INFO  b.s.l.ThriftAccessLogger - Request ID: 7 access 
from:  principal:  operation: getUserTopology

76123 [pool-475-thread-3] INFO  b.s.l.ThriftAccessLogger - Request ID: 8 access 
from:  principal:  operation: getTopologyInfo

76124 [main] INFO  b.s.d.nimbus - Shutting down master

76126 [main] INFO  b.s.zookeeper - closing zookeeper connection of leader 
elector.

76127 [main] INFO  b.s.d.nimbus - Shut down master

76130 [main] INFO  b.s.testing - Shutting down in process zookeeper

76132 [main] INFO  b.s.testing - Done shutting down in process zookeeper

76132 [main] INFO  b.s.testing - Deleting temporary path 
/tmp/1fe384ec-a2f5-4985-a31b-3a419b85504b

76132 [main] INFO  b.s.testing - Deleting temporary path 
/tmp/632fb133-326b-4c26-91a5-03f1bbe933d2

Tests run: 5, Passed: 36, Failures: 3, Errors: 0
{noformat}

Sometimes, 3 tests that should trivially pass do not.

>From the logs, it seems the three tests that fail are:

* Simple-authentication-test
* test-noop-authorization-w-simple-transport
* test-noop-authorization-w-sasl-digest

Since each of these should trivially pass, it seems the nimbus client in these 
three tests was not talking to the correct nimbus instance.

We could add locking in the with-test-cluster macro to ensure the cluster fully 
shuts down before another test runs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to