Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/885#discussion_r47586077
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -149,9 +150,9 @@ public EmitState next(SpoutOutputCollector collector) {
}
if ((tups != null) && tups.iterator().hasNext()) {
- if(_spoutConfig.topicAsStreamId) {
+ if (!Strings.isNullOrEmpty(_spoutConfig.outputStreamId)) {
--- End diff --
Isn't it an overkill to import a whole package
(com.google.common.base.Strings) to only test for null or empty? Can't we just
use:
if (_spoutConfig.outputStreamId!=null && _spoutConfig.outputStreamId!="")
or something to that effect instead of importing a new library?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
