Github user redsanket commented on a diff in the pull request:

    https://github.com/apache/storm/pull/933#discussion_r47598080
  
    --- Diff: storm-core/test/clj/backtype/storm/nimbus_test.clj ---
    @@ -1238,10 +1238,11 @@
       (testing "nimbus-data uses correct ACLs"
         (let [scheme "digest"
               digest "storm:thisisapoorpassword"
    -          auth-conf {STORM-ZOOKEEPER-AUTH-SCHEME scheme
    +          auth-conf (merge (read-storm-config)
    +                    {STORM-ZOOKEEPER-AUTH-SCHEME scheme
                          STORM-ZOOKEEPER-AUTH-PAYLOAD digest
                          STORM-PRINCIPAL-TO-LOCAL-PLUGIN 
"backtype.storm.security.auth.DefaultPrincipalToLocal"
    -                     NIMBUS-THRIFT-PORT 6666}
    +                     NIMBUS-THRIFT-PORT 6666})
    --- End diff --
    
    All the test cases in this file have a similar port, will create a JIRA to 
tackle this issue separately as I feel it is not a part of this change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to