Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/941#discussion_r47642414
--- Diff:
storm-core/test/clj/backtype/storm/security/auth/ThriftClient_test.clj ---
@@ -20,26 +20,26 @@
(:import [org.apache.thrift.transport TTransportException])
)
+(def TIMEOUT (Integer. (* 3 1000)))
--- End diff --
> Are we going from 30 seconds to 3000 miliseconds here? Shouldn't it be
30000?
30 seconds is an extremely long timeout for a thrift response. Most of the
time, 30ms is enough. If the thrift server does not reply within 3 full
seconds, I am done waiting for it.
> How about adding a comment describing why the choice of 3000 in this
particular test?
Yes, I can add a shorter comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
