[
https://issues.apache.org/jira/browse/STORM-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058138#comment-15058138
]
ASF GitHub Bot commented on STORM-1377:
---------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/941#discussion_r47642414
--- Diff:
storm-core/test/clj/backtype/storm/security/auth/ThriftClient_test.clj ---
@@ -20,26 +20,26 @@
(:import [org.apache.thrift.transport TTransportException])
)
+(def TIMEOUT (Integer. (* 3 1000)))
--- End diff --
> Are we going from 30 seconds to 3000 miliseconds here? Shouldn't it be
30000?
30 seconds is an extremely long timeout for a thrift response. Most of the
time, 30ms is enough. If the thrift server does not reply within 3 full
seconds, I am done waiting for it.
> How about adding a comment describing why the choice of 3000 in this
particular test?
Yes, I can add a shorter comment.
> nimbus_auth_test: very short timeouts causing spurious failures
> ---------------------------------------------------------------
>
> Key: STORM-1377
> URL: https://issues.apache.org/jira/browse/STORM-1377
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Derek Dagit
> Assignee: Derek Dagit
> Priority: Minor
>
> This is caused by a units mismatch. We are waiting 30 ms for the thrift
> server to reply when we thought we were waiting 30s. This means that
> sometimes when we expect NotAliveException, we instead get
> TTransportException(SocketTimeoutException), and this fails the assertions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
