[
https://issues.apache.org/jira/browse/STORM-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058307#comment-15058307
]
ASF GitHub Bot commented on STORM-1187:
---------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/900#discussion_r47663680
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -1697,19 +1697,45 @@
public static final String TOPOLOGY_BOLTS_WINDOW_LENGTH_DURATION_MS =
"topology.bolts.window.length.duration.ms";
/*
- * Bolt-specific configuration for windowed bolts to specifiy the
sliding interval as a count of number of tuples.
+ * Bolt-specific configuration for windowed bolts to specify the
sliding interval as a count of number of tuples.
*/
@isInteger
@isPositiveNumber
public static final String TOPOLOGY_BOLTS_SLIDING_INTERVAL_COUNT =
"topology.bolts.window.sliding.interval.count";
/*
- * Bolt-specific configuration for windowed bolts to specifiy the
sliding interval in time duration.
+ * Bolt-specific configuration for windowed bolts to specify the
sliding interval in time duration.
*/
@isInteger
@isPositiveNumber
public static final String TOPOLOGY_BOLTS_SLIDING_INTERVAL_DURATION_MS
= "topology.bolts.window.sliding.interval.duration.ms";
+ /*
+ * Bolt-specific configuration for windowed bolts to specify the name
of the field in the tuple that holds
+ * the timestamp (e.g. the ts when the tuple was actually generated).
If this config is specified and the
+ * field is not present in the incoming tuple, a
java.lang.IllegalArgumentException will be thrown.
+ */
+ @isString
+ public static final String TOPOLOGY_BOLTS_TUPLE_TIMESTAMP_FIELD_NAME =
"topology.bolts.tuple.timestamp.field.name";
--- End diff --
any reason for this config to have BOLT in them , can't we name it as
topology.tuple.timestamp.field.name
> Support for late and out of order events in time based windows
> --------------------------------------------------------------
>
> Key: STORM-1187
> URL: https://issues.apache.org/jira/browse/STORM-1187
> Project: Apache Storm
> Issue Type: Sub-task
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
>
> Right now the time based windows uses the timestamp when the tuple is
> received by the bolt.
> However there are use cases where the tuples can be processed based on the
> time when they are actually generated vs the time when they are received. So
> we need to add support for processing events with a time lag and also have
> some way to specify and read tuple timestamps.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)