Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/959#discussion_r48112013
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -480,6 +480,27 @@ private String getStringFromStringList(Object o) {
* */
private Double getAssignedMemoryForSlot(Map topConf) {
Double totalWorkerMemory = 0.0;
+ final Integer TOPOLOGY_WORKER_DEFAULT_MEMORY_ALLOCATION = 768;
+
+ String topologyWorkerGcChildopts = null;
--- End diff --
Do not see any harm of this null assignment, more of a habitual choice.
Same below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
