[
https://issues.apache.org/jira/browse/STORM-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065977#comment-15065977
]
ASF GitHub Bot commented on STORM-1403:
---------------------------------------
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/959#discussion_r48112013
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
@@ -480,6 +480,27 @@ private String getStringFromStringList(Object o) {
* */
private Double getAssignedMemoryForSlot(Map topConf) {
Double totalWorkerMemory = 0.0;
+ final Integer TOPOLOGY_WORKER_DEFAULT_MEMORY_ALLOCATION = 768;
+
+ String topologyWorkerGcChildopts = null;
--- End diff --
Do not see any harm of this null assignment, more of a habitual choice.
Same below.
> Consider gc childopts in JVM calculation for resource display
> -------------------------------------------------------------
>
> Key: STORM-1403
> URL: https://issues.apache.org/jira/browse/STORM-1403
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 0.11.0
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Priority: Minor
> Fix For: 0.11.0
>
>
> Need to consider worker.gc.childopts and topology.worker.gc.childopts when
> calculating per-worker memory usage for UI display
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
